feat(spice): non-tracking validators pull witness for fallback (4/6)#15940
Open
darioush wants to merge 1 commit into
Open
feat(spice): non-tracking validators pull witness for fallback (4/6)#15940darioush wants to merge 1 commit into
darioush wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## darioush/spice/all-stake-fallback-certify #15940 +/- ##
=============================================================================
- Coverage 72.65% 72.64% -0.01%
=============================================================================
Files 953 953
Lines 205417 205515 +98
Branches 205417 205515 +98
=============================================================================
+ Hits 149254 149306 +52
- Misses 51169 51202 +33
- Partials 4994 5007 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Enables SPICE all-stake fallback certification to progress even when a validator is not designated for a chunk and does not track the chunk’s shard, by having the data distributor proactively pull the chunk’s witness once it becomes fallback-eligible. Adds supporting test-loop infrastructure and end-to-end fallback tests that simulate a full designated-endorser outage and an epoch-boundary transition.
Changes:
- Add per-processed-block logic in
SpiceDataDistributorActorto request fallback-eligible witnesses for non-designated, non-tracking epoch validators. - Extend SPICE endorsement primitives with
SpiceChunkEndorsement::shard_id()and add test-loop helpers for observing certification progress and selectively dropping designated endorsements. - Add new test-loop SPICE e2e tests covering fallback-only certification and certification across an epoch boundary.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test-loop-tests/src/utils/node.rs | Adds last_certified_block_header() helper for fallback e2e assertions. |
| test-loop-tests/src/utils/network.rs | Adds a network dropper that filters designated SPICE endorsements to force fallback-only certification in tests. |
| test-loop-tests/src/tests/spice/mod.rs | Registers the new all_stake_fallback test module. |
| test-loop-tests/src/tests/spice/all_stake_fallback.rs | New e2e tests for fallback-only certification and across-epoch-boundary certification. |
| test-loop-tests/src/setup/drop_condition.rs | Adds DropCondition::DesignatedSpiceEndorsements wiring to install the new dropper. |
| core/primitives/src/spice/chunk_endorsement.rs | Adds SpiceChunkEndorsement::shard_id() accessor used by tests/infrastructure. |
| chain/client/src/spice/data_distributor_actor.rs | Implements contribute_fallback_endorsements and witness-pull initiation for fallback-eligible uncertified chunks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
darioush
changed the title
darioush
force-pushed
the
darioush/spice/all-stake-fallback-certify
branch
from
1df6ba7 to
5b84f99
Compare
darioush
force-pushed
the
darioush/spice/all-stake-fallback-witness
branch
from
727c38b to
c2c9b00
Compare
darioush
force-pushed
the
darioush/spice/all-stake-fallback-witness
branch
from
c2c9b00 to
27d7b18
Compare
darioush
force-pushed
the
darioush/spice/all-stake-fallback-certify
branch
from
5b84f99 to
f247cee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets a non-designated epoch validator that doesn't track a chunk's shard contribute to the all-stake fallback. Once a chunk is past the fallback window and still uncertified, the data distributor pulls the chunk's witness (
start_waiting_on_fallback_witness) so the validator can apply and endorse it; the existing witness-validation flow then broadcasts the endorsement, which the fallback tally certifies.contribute_fallback_endorsementsruns per processed block: for each uncertified, fallback-eligible chunk the node is a non-designated epoch validator of, it pulls the witness if it isn't already tracking the shard or hasn't already endorsed.Adds
SpiceChunkEndorsement::shard_id()and the test infra used by the fallback e2e tests: aDesignatedSpiceEndorsementsdrop condition (drops endorsements from designated senders so chunks can certify only via the fallback) and alast_certified_block_headernode helper.e2e: certifies-without-designated-endorsements (total designated outage) and certifies-across-epoch-boundary.